Gate blob reads on in-progress writes to prevent spurious NotFound#342
Open
sean- wants to merge 2 commits intothought-machine:masterfrom
Open
Gate blob reads on in-progress writes to prevent spurious NotFound#342sean- wants to merge 2 commits intothought-machine:masterfrom
sean- wants to merge 2 commits intothought-machine:masterfrom
Conversation
When concurrent targets upload and read the same blob simultaneously, the reader can get a NotFound error because the write hasn't landed yet. This was observed in CI where GetTree failed for a blob being uploaded via BatchUpdateBlobs at the exact same millisecond. Add an inflightWrites tracker that gates read operations on any in-progress write for the same digest hash. Uses context.WithCancel so parent context cancellation propagates naturally. All write paths (writeAll for BatchUpdateBlobs, writeBlob for ByteStream.Write) register with the tracker, and all read paths (readAllBlobCompressed, readCompressed) wait for completion before proceeding. Also bumps Go toolchain from 1.23.2 to 1.24.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When concurrent targets upload and read the same blob simultaneously, the reader can get a
NotFounderror because the write hasn't landed yet. This was observed in CI whereGetTreefailed for a blob being uploaded viaBatchUpdateBlobsat the exact same millisecond.Add an
inflightWritestracker that gates read operations on any in-progress write for the same digest hash. Usescontext.WithCancelso parent context cancellation propagates naturally. All write paths (writeAllforBatchUpdateBlobs,writeBlobforByteStream.Write) register with the tracker, and all read paths (readAllBlobCompressed,readCompressed) wait for completion before proceeding.Also bumps Go toolchain from 1.23.2 to 1.24.2.