Closed
Conversation
- create openrpc.json spec file that represent all zos types and api handlers - create a tool that generate go types/methods from the spec file with the limitation for the `net/rpc` package services
- seperate the perf task getters to have a method for each task with a
defined result type instead of interface{}
- modify healthcheck task to have its result as slice of object
containes the check name instead of map from name to error
- modify public ip task to have its result as slice of reports with the
ip included instead of map from the ip to report
- update performance monitor stub
- modify the diagnositcs response to be slice of modules status instead
of map
Omarabdul3ziz
force-pushed
the
main_openrpc
branch
from
0c6c21d to
7c12991
Compare
Contributor
Author
|
close for threefoldtech/zosbase#26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pr contains
net/rpcpackageInternal modifications:
defined result type instead of interface{}
containes the check name instead of map from name to error
ip included instead of map from the ip to report
of map
Related issues