Fix sync-versions auth for private repo clones#4547
Merged
caseydavenport merged 1 commit intotigera:masterfrom Mar 13, 2026
Merged
Fix sync-versions auth for private repo clones#4547caseydavenport merged 1 commit intotigera:masterfrom
caseydavenport merged 1 commit intotigera:masterfrom
Conversation
actions/checkout injects an extraheader with the default GITHUB_TOKEN into the repo's local git config, which takes precedence over our credential helper. Since GITHUB_TOKEN only has access to tigera/operator, this was causing auth failures when cloning tigera/calico-private.
coutinhop
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #4544 — turns out
actions/checkout@v4injects anhttp.<url>.extraheaderinto the repo's local git config containing the defaultGITHUB_TOKEN. This takes precedence over credential helpers at the protocol level, so ourcredential.helper storewithMARVIN_PATwas never actually being used for thecalico-privateclone. SinceGITHUB_TOKENonly has access totigera/operator, the clone fails with "Invalid username or token".Adding
persist-credentials: falseto the checkout step prevents it from injecting that extraheader, letting our credential helper handle auth instead.