Open
Conversation
* [jcruz/MSE-4519] creates function to get message type and build analytics label for android [skip ci] * [jcruz/MSE-4519] ingores beam files and _build directory * [jcruz/MSE-4519] adds analytics label on adnorid options for fcm * [jcruz/MSE-4519] adds test for analytics label creation * [jcruz/MSE-4519] updates rebar deps * [jcruz/MSE-4519] updates travis yaml * [jcruz/MSE-4519] updates travis yaml * [jcruz/MSE-4519] updates travis yaml * [jcruz/MSE-4519] updates travis yaml 2 * [jcruz/MSE-4519] updates travis yaml 2 * [jcruz/MSE-4519] updates travis yaml 3 * [jcruz/MSE-4519] updates rebar deps versions * [jcruz/MSE-4519] removes skip_deps options * [jcruz/MSE-4519] adds cxy dep * [jcruz/MSE-4519] updates cxy version * [jcruz/MSE-4519] updates rebar lock * [jcruz/MSE-4519] updates travis and rebar config * [jcruz/MSE-4519] ignores xml files * [jcruz/MSE-4519] removes epocxy * [jcruz/MSE-4519] mocks cxy calls in tests * [jcruz/MSE-4519] adds .tool-versions file for asdf * [jcruz/MSE-4519] removes debug line for travis ci
* [jcruz/MS-635] adds erlang ls config * [jcruz/MS-635] fixes bad caluse * [jcruz/MS-635] updates travis yaml * [jcruz/MS-635] adds parsetools to trabis * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] adds updates travis yaml * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates travis yamel * [jcruz/MS-635] updates rebar config * [jcruz/MS-635] updates rebar config * [jcruz/MS-635] changes dependencies to url * [jcruz/MS-635] updates rebar lock * [jcruz/MS-635] adds transitional dependency * [jcruz/MS-635] updates lock
There was a problem hiding this comment.
Pull request overview
This PR adds analytics tracking functionality to push notifications by introducing an analytics_label field to the FCM payload. The label combines a prefix with the message type to enable better tracking of notification delivery.
Key Changes:
- Added analytics label construction in
gcm_request.erlwith helper functions to extract message type and build the label - Updated test mocking setup to handle the new
cxy_ctldependency and modified HTTP request expectations - Added comprehensive unit tests for the new analytics functionality
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/gcm_request.erl | Core implementation: adds build_analytics_label/2 and get_msg_type/1 functions, integrates analytics label into Android push payload |
| test/gcm_request_test.erl | Unit tests for message type extraction and analytics label construction |
| test/gcm_test.erl | Updates mocking setup to include cxy_ctl and adjusts HTTP request expectations to accept options parameter |
| .travis.yml | Updates CI configuration with explicit dependency fetching and newer OTP release |
| .tool-versions | Specifies Erlang and Rebar versions for development environment |
| erlang_ls.config | Adds Erlang Language Server configuration for IDE support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new analytics field to push notifications payload