test: expand unit and integration test coverage#85
Merged
designcode merged 2 commits intomainfrom Apr 10, 2026
Merged
Conversation
The specs.yaml default: none caused Commander to always set compressionArg, preventing auto-detection from output file extension (.tar.gz → gzip). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Unit tests for previously untested utilities and auth modules: - upload.ts: calculateUploadParams boundary cases - concurrency.ts: pool limiting, ordering, error propagation - bucket-info.ts: all conditional branches (TTL, lifecycle, CORS, etc.) - interactive.ts: TTY detection guard - auth/fly.ts: Fly org prefix detection - auth/iam.ts: OAuth and credential config resolution branches Integration tests for access-keys lifecycle: - create, get, list, assign (bucket + admin), revoke, rotate, delete - Error cases for missing args and confirmation prompts Also adds OAuth-guarded test block for IAM policies, users, and orgs (skipped unless TIGRIS_OAUTH_TEST=true), and whoami command tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
MantasMiksys
approved these changes
Apr 10, 2026
|
🎉 This PR is included in version 2.18.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
default: nonefrom specs)New unit tests
test/utils/upload.test.tscalculateUploadParamsboundary casestest/utils/concurrency.test.tstest/utils/bucket-info.test.tstest/utils/interactive.test.tstest/auth/fly.test.tstest/auth/iam.test.tsNew integration tests
TIGRIS_OAUTH_TEST=true): IAM policies lifecycle, users list, orgs listTest plan
npm test— 643 unit tests passnpm run test:integration— all integration tests passnpm run lint:fix— no errors🤖 Generated with Claude Code
Note
Low Risk
Primarily adds tests and gating for OAuth-only integration coverage; the only behavior-adjacent change is a spec/default tweak for
bundle --compression, which is low risk but could affect CLI defaults if the spec is used for argument parsing.Overview
Expands test coverage across auth, utilities, and CLI workflows. Adds new unit tests for
isFlyOrganization,getOAuthIAMConfig/getIAMConfig, and several utility helpers (bucket info formatting, concurrency limiting, interactive/TTY guard, and multipart upload parameter calculation).Broadens integration coverage for operational commands. Extends
cli.test.tswith end-to-end lifecycle tests foraccess-keys(create/assign/rotate/delete), addswhoamiassertions, and introduces an OAuth-gated integration block (enabled viaTIGRIS_OAUTH_TEST=true) to exercise IAM policy/user/org listing flows.CLI spec tweak. Updates
bundle’s--compressionoption description to indicate auto-detection from output extension and removes the explicit default.Reviewed by Cursor Bugbot for commit 1e40560. Bugbot is set up for automated code reviews on this repo. Configure here.