Skip to content

fix: improve update command resolution and restrict brew updates to stable #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
designcode merged 3 commits into from
Apr 13, 2026
Merged

fix: improve update command resolution and restrict brew updates to stable #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c885996
fix: update command resolution
designcode Apr 12, 2026
c16663e
fix: update brew for stable releases only
designcode Apr 12, 2026
8e6fcc5
fix: check isBinary before isHomebrewInstall to avoid false positives
designcode Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ jobs:

update-homebrew:
needs: [release, build-binaries]
if: needs.release.outputs.new_release_published == 'true'
if: needs.release.outputs.new_release_published == 'true' && github.ref == 'refs/heads/release'
runs-on: ubuntu-latest

steps:
Expand Down
23 changes: 15 additions & 8 deletions src/utils/update-check.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { execSync } from 'child_process';
import { mkdirSync, readFileSync, writeFileSync } from 'fs';
import { mkdirSync, readFileSync, realpathSync, writeFileSync } from 'fs';
import https from 'https';
import { homedir } from 'os';
import { join } from 'path';
Expand Down Expand Up @@ -96,8 +95,8 @@ export function isNewerVersion(current: string, latest: string): boolean {
function isHomebrewInstall(): boolean {
if (process.platform === 'win32') return false;
try {
execSync('brew list tigris', { stdio: 'ignore' });
return true;
const resolved = realpathSync(process.execPath);
return resolved.includes('/Cellar/') || resolved.includes('/Caskroom/');
} catch {
return false;
}
Expand All @@ -109,15 +108,23 @@ function isHomebrewInstall(): boolean {
export function getUpdateCommand(): string {
const isBinary =
(globalThis as { __TIGRIS_BINARY?: boolean }).__TIGRIS_BINARY === true;
const isWindows = process.platform === 'win32';

// npm install — process.execPath is Node, not our binary.
// Must come before isHomebrewInstall() to avoid false positives
// when Node itself was installed via Homebrew.
if (!isBinary) {
return 'npm install -g @tigrisdata/cli';
} else if (isHomebrewInstall()) {
}
// Standalone binary installed via Homebrew (execPath resolves to /Cellar/ or /Caskroom/)
else if (isHomebrewInstall()) {
return 'brew upgrade tigris';
} else if (isWindows) {
}
// Standalone binary on Windows
else if (process.platform === 'win32') {
return 'irm https://github.com/tigrisdata/cli/releases/latest/download/install.ps1 | iex';
} else {
}
// Standalone binary on macOS/Linux (installed via curl)
else {
return 'curl -fsSL https://github.com/tigrisdata/cli/releases/latest/download/install.sh | sh';
}
}
Expand Down