Skip to content

fix(storage): paginationToken in list bucket#77

Merged
designcode merged 2 commits intomainfrom
fix/pagination-tokens
Apr 7, 2026
Merged

fix(storage): paginationToken in list bucket#77
designcode merged 2 commits intomainfrom
fix/pagination-tokens

Conversation

@designcode
Copy link
Copy Markdown
Collaborator

@designcode designcode commented Apr 7, 2026

Note

Medium Risk
Low-to-moderate risk: changes the listBuckets response shape by adding paginationToken, and updates several build/runtime dependencies in package-lock.json, which could affect consumers and tooling.

Overview
Fixes bucket listing pagination by returning paginationToken (from S3 ContinuationToken) in packages/storage/src/lib/bucket/list.ts so callers can request subsequent pages.

Also bumps dependency versions (notably dotenv, vite/rolldown, and lodash) via package-lock.json, and updates packages/keyv-tigris/package.json to use dotenv ^17.4.1.

Reviewed by Cursor Bugbot for commit 1df8de0. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 7, 2026

Greptile Summary

This PR fixes listBuckets to actually return the paginationToken in its response. The ListBucketsResponse type already declared the field as optional, but it was never being populated from the AWS SDK's ContinuationToken response field — so callers had no way to know whether more pages existed. The fix is a one-line addition in the correct place. The other changes are a routine dotenv patch bump and associated lockfile updates.

Confidence Score: 5/5

Safe to merge — the fix is minimal, correct, and has no breaking changes.

The core change is a single line that correctly wires res.ContinuationToken (confirmed by AWS SDK docs as the next-page token) into the already-typed paginationToken field. No logic is altered elsewhere, and the remaining changes are non-functional dependency bumps.

No files require special attention.

Important Files Changed

Filename Overview
packages/storage/src/lib/bucket/list.ts Adds the paginationToken field to the returned data object, correctly reading from the AWS SDK response; the type already declared this field as optional.
packages/keyv-tigris/package.json Minor dependency bump: dotenv from ^17.3.1 to ^17.4.1.
package-lock.json Lockfile updated to reflect dotenv, vite, rolldown, @oxc-project/types, and @napi-rs/wasm-runtime version bumps; no functional concerns.

Reviews (1): Last reviewed commit: "fix(storage): paginationToken in list bu..." | Re-trigger Greptile

@designcode designcode merged commit f707176 into main Apr 7, 2026
2 checks passed
@designcode designcode deleted the fix/pagination-tokens branch April 7, 2026 18:22
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

🎉 This PR is included in version 2.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants