Vulkan: consolidate outline cvar wiring; fix STANDALONE comment#56
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Vulkan: consolidate outline cvar wiring; fix STANDALONE comment#56cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Register r_outline and r_outlineThreshold once in tr_init and reuse globals in the post-process pipeline and PostFX param upload, removing redundant Cvar_Get calls while preserving CVAR_ARCHIVE and defaults. Also fix a misleading #endif comment in sv_ccmds.c (STANDALONE guard). Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cvar_Getcalls forr_outline/r_outlineThresholdinto a single registration intr_init.cwith the same names, defaults (0/0.15), andCVAR_ARCHIVE. Consumers now read the sharedcvar_tpointers. Corrects a misleading#endifcomment insv_ccmds.cto match the actual#ifndef STANDALONEguard (no behavior change)../scripts/compile_engine.sh;ctestinbuild-vk-Release(17/17 passed, including smoke and unit tests).Notes
USE_BANSis referenced in server sources but is not defined anywhere in CMake or headers, so file-based ban enforcement is compiled out. Enabling it would change dedicated-server behavior; needs an explicit product decision before defining it in the build.