Remove dead ENABLE_ALTROUTING preprocessor branches in botlib#57
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Remove dead ENABLE_ALTROUTING preprocessor branches in botlib#57cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
ENABLE_ALTROUTING was unconditionally defined in every copy of be_aas_routealt.c, so the #ifndef path never compiled. Drop the macro and preprocessor guards to keep the always-on alternative routing path only. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a stale compile-time feature gate in AAS alternative routing. The macro was always defined, so the disabled branch was dead code.
Flags removed
ENABLE_ALTROUTING(compile-time macro inbe_aas_routealt.c)Why it is safe to delete
#defined unconditionally at the top of every copy ofbe_aas_routealt.c(src/botlib/,src/platform/botlib/,src/platform/win32/botlib/). Nothing in the tree ever undefines it or builds without it.#ifndef ENABLE_ALTROUTINGpath (return 0stub and empty init/shutdown) therefore never compiled in any shipped configuration.Behavioral parity checks performed
./scripts/compile_engine.sh opengl(Release) — succeeded.ctestinbuild-gl-Release— all 17 tests passed (smoke, renderer regression check, unit tests).Files
src/botlib/be_aas_routealt.csrc/platform/botlib/be_aas_routealt.csrc/platform/win32/botlib/be_aas_routealt.c