Fix finger tip transform, so collision body is at fingertip, not at wrist#1
Open
nachbar wants to merge 2 commits intotimmitra:mainfrom
Open
Fix finger tip transform, so collision body is at fingertip, not at wrist#1nachbar wants to merge 2 commits intotimmitra:mainfrom
nachbar wants to merge 2 commits intotimmitra:mainfrom
Conversation
parentFromJointTransform only gives the transform from the previous joint (the distal interphalangeal joint in the case of the fingertip), whereas anchorFromJointTransform gives the transform between the index fingertip and the wrist Also, add commented-out diagnostic code for walking the skeleton back to the wrist, reporting the joints and the distances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed parentFromJointTransform to anchorFromJointTransform; the former only gives the transform from the previous joint, which is the distal interphalangeal joint; the latter gives the transform from the wrist.
Also added commented-out code documenting how to inspect the skeleton