Open
Conversation
Fixes #106 This change adds the necessary intent filters and handling code to allow Shuttle2 to be recognized by Android as a music player application. Changes: - Add MUSIC_PLAYER action to register as a music player - Add ACTION_VIEW intent filters for audio file types (audio/*, application/ogg, application/x-ogg, application/itunes) - Update MainActivity to handle ACTION_VIEW intents for audio files - Update PlaybackService to process ACTION_VIEW intents via media session This allows users to: - Set Shuttle2 as the default music player - Open audio files from file managers and other apps with Shuttle2 - Have Shuttle2 recognized by other apps that integrate with music players
Contributor
I haven't found any option in my phone or the emulator to set the default music player, and I'm not sure what the third item refers to. However, I've tested opening files from a file manager and it doesn't work as it is. There are some things missing that I needed to add for it to work properly. You can find the changes in the branch alexm-106-open-audio-files-intent (rebased to main), if you want to cherry-pick them. Or I can open a separate pull request, if you prefer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
This change adds the necessary intent filters and handling code to allow Shuttle2 to be recognized by Android as a music player application.
Changes:
This allows users to: