Adds news aggregator example in Python and JavaScript#120
Merged
nearestnabors merged 7 commits intomainfrom Feb 14, 2025
Merged
Adds news aggregator example in Python and JavaScript#120nearestnabors merged 7 commits intomainfrom
nearestnabors merged 7 commits intomainfrom
Conversation
frankfeng98
approved these changes
Feb 14, 2025
Contributor
frankfeng98
left a comment
frankfeng98
left a comment
There was a problem hiding this comment.
LGTM! Just some nits.
|
|
||
| # Set up logging | ||
| logging.basicConfig(level=logging.INFO) | ||
| LOG = logging.getLogger(__name__) |
Contributor
There was a problem hiding this comment.
We typically use lowercase for log variable.
nearestnabors
commented
Feb 14, 2025
nearestnabors
commented
Feb 14, 2025
nearestnabors
commented
Feb 14, 2025
nearestnabors
commented
Feb 14, 2025
nearestnabors
commented
Feb 14, 2025
frankfeng98
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Says what it does. Needed for livestream + workshop