Skip to content

DOC-3243: Errors when creating new comments made the save button stuck in a saving state. #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kemister85 merged 3 commits into from
Mar 26, 2026
Merged

DOC-3243: Errors when creating new comments made the save button stuck in a saving state. #4030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65f64e0
Docs: DOC-3243 - Errors when creating new comments made the save butt…
kemister85 Mar 18, 2026
59673e0
Docs: DOC-3243 - Fix release note placement per review
kemister85 Mar 18, 2026
62e21ef
Merge branch 'feature/8.4.0/DOC-3243' into feature/8.4.0/DOC-3243_TIN…
kemister85 Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions modules/ROOT/pages/8.4.0-release-notes.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,21 +57,6 @@ For information on the **<Open source plugin name>** plugin, see xref:<plugincod

The following premium plugin updates were released alongside {productname} {release-version}.

=== Full Page HTML

The {productname} {release-version} release includes an accompanying release of the **Full Page HTML** premium plugin.

**Full Page HTML** includes the following addition.

==== New argument `fullpagehtml` to `editor.getContent()` and `editor.setContent()` APIs to only get/set the body of the content while the full page plugin is active.
// #TINY-13744

Previously, setting and getting the editor content while the Full Page HTML plugin was active could be troublesome due to the presence of the full HTML document on all API calls, even when not needed. Attempting to get and act only on the body content (for example, for saving) was undocumented and required workarounds.

In {productname} {release-version}, the `fullpagehtml` option has been added to the `editor.getContent()` and `editor.setContent()` APIs. When set to `false`, this option allows getting and setting only the body content while the Full Page HTML plugin is active, without interfering with the full document structure. The document is now more resistant to accidental changes, and content can be retrieved or updated without including the full HTML document. For details, see xref:fullpagehtml.adoc#fullpagehtml-getcontent-setcontent[`fullpagehtml` option for getContent/setContent].

For information on the **Full Page HTML** plugin, see: xref:fullpagehtml.adoc[Full Page HTML].

=== Media Optimizer

The {productname} {release-version} release includes an accompanying release of the **Media Optimizer** premium plugin.
Expand All @@ -91,7 +76,7 @@ For information on the **Media Optimizer** plugin, see: xref:uploadcare.adoc[Med

The {productname} {release-version} release includes an accompanying release of the **Full Page HTML** premium plugin.

**Full Page HTML** includes the following fix.
**Full Page HTML** includes the following fixes.

==== Pasting an HTML document was vulnerable to XSS attacks
// #TINY-13673
Expand All @@ -100,8 +85,30 @@ A cross-site scripting (XSS) vulnerability was discovered in the Full Page HTML

This vulnerability has been patched in {productname} {release-version} by ensuring that content in the document `<head>` is properly encoded.

==== New argument `fullpagehtml` to `editor.getContent()` and `editor.setContent()` APIs to only get/set the body of the content while the full page plugin is active.
// #TINY-13744

Previously, setting and getting the editor content while the Full Page HTML plugin was active could be troublesome due to the presence of the full HTML document on all API calls, even when not needed. Attempting to get and act only on the body content (for example, for saving) was undocumented and required workarounds.

In {productname} {release-version}, the `fullpagehtml` option has been added to the `editor.getContent()` and `editor.setContent()` APIs. When set to `false`, this option allows getting and setting only the body content while the Full Page HTML plugin is active, without interfering with the full document structure. The document is now more resistant to accidental changes, and content can be retrieved or updated without including the full HTML document. For details, see xref:fullpagehtml.adoc#fullpagehtml-getcontent-setcontent[`fullpagehtml` option for getContent/setContent].

For information on the **Full Page HTML** plugin, see: xref:fullpagehtml.adoc[Full Page HTML].

=== Comments

The {productname} {release-version} release includes an accompanying release of the **Comments** premium plugin.

**Comments** includes the following fix.

==== Errors when creating new comments made the save button stuck in a saving state.
// #TINY-12224

Previously, when creating or editing a comment in Comments, the save button could remain in a saving state indefinitely if the save operation failed or if the component was not replaced. The saving state had no way to reset to false except by recreating the component, which misled users into thinking the operation was still in progress.

In {productname} {release-version}, the save logic now resets the saving state to false after the save operation completes, whether the operation succeeds or fails. The save button no longer remains stuck in a saving state.

For information on the **Comments** plugin, see: xref:introduction-to-tiny-comments.adoc[Comments].

[[accompanying-premium-plugin-end-of-life-announcement]]
== Accompanying Premium plugin end-of-life announcement

Expand Down
Loading