Skip to content

Fix Error Handling to output JSON#4

Open
tjp2021 wants to merge 8 commits intomasterfrom
acme-api-fix-json
Open

Fix Error Handling to output JSON#4
tjp2021 wants to merge 8 commits intomasterfrom
acme-api-fix-json

Conversation

@tjp2021
Copy link
Owner

@tjp2021 tjp2021 commented Sep 9, 2018

All Error handling has been modified from puts statements to something more actionable. Puts statements in controller have been swapped to render json: { error handling hash }.

The error handling in both the FakepayService.rb and Customer.rb model have been changed from puts statements to return json: { error handling hash }

I'm unsure if this is the appropriate syntax or way to return json objects that have messages inside.

@speric
Copy link

speric commented Sep 9, 2018

I think we should write some tests for this. Do you want to pair on tests tomorrow (Monday)?

@tjp2021
Copy link
Owner Author

tjp2021 commented Sep 10, 2018

@speric That sounds good to me. Send over a calendar invite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants