Open
Conversation
…sed before plan pricing method is called '
|
I think we should write some tests for this. Do you want to pair on tests tomorrow (Monday)? |
Owner
Author
|
@speric That sounds good to me. Send over a calendar invite? |
…ice for separation of concerns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Error handling has been modified from puts statements to something more actionable. Puts statements in controller have been swapped to render json: { error handling hash }.
The error handling in both the FakepayService.rb and Customer.rb model have been changed from puts statements to return json: { error handling hash }
I'm unsure if this is the appropriate syntax or way to return json objects that have messages inside.