Fix defaults when dumping ruby schema#27
Open
bsedat wants to merge 3 commits intotlconnor:masterfrom
bsedat:feature/schema-dumping
Open
Fix defaults when dumping ruby schema#27bsedat wants to merge 3 commits intotlconnor:masterfrom bsedat:feature/schema-dumping
bsedat wants to merge 3 commits intotlconnor:masterfrom
bsedat:feature/schema-dumping
Conversation
…at, integer, and timestamp casting
…ray columns that contain defaults
Contributor
|
+1 this |
|
It would be great if this got merged. We have an array field in our database with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an issue where the schema dump contained the string version of the column default (ie "{foo,bar}"), causing errors when the schema was loaded.
I did some digging and saw that type_cast gets called to extract the default value when dumping the schema and I added a method chain to detect array columns and properly extract them.