Added support for parsing multi-dimensional array string#33
Open
saurabhnanda wants to merge 12 commits intotlconnor:masterfrom
Open
Added support for parsing multi-dimensional array string#33saurabhnanda wants to merge 12 commits intotlconnor:masterfrom
saurabhnanda wants to merge 12 commits intotlconnor:masterfrom
Conversation
* Used the Sequel::Postgres::PGArray::Parser class from https://github.com/jeremyevans/sequel/blob/master/lib/sequel/extensions/pg_array.rb * The saner method to parse multi-dimensional array-strings is to NOT use regexps and use some sort of parser instead * Changed String.valid_postgres_array? to use constants instead of variables to defined the regexps * Converting timestamps to current Rails timezone using `in_time_zone`
Removed String.valid_postgres_array? because there is no easy way to validate array-string using Regexps alone. One will have to parse the string into an array to check if it's valid -- a task that the PG database would anyways do. Removed check in `quote_with_array`
Author
|
Did you get a chance to review this PR? |
…es because the actual function in Rails 3.2.x has changed. The monkeypatched version was unable to handle serialized attributes and was causing all serializations to barf.
* Removed the method_chaing for quote_without_array, because it's not required in the new approach.
* Added ActiveRecord::Coders::PgArray to act as a serializer/de-serializer for all array columns. One has to expilicity define how to serialize a column, like:
`serialize :tags, ActiveRecord::Coders::PgArray(:string)`
… we override the reader method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for parsing multi-dimensional array strings
in_time_zone