Skip to content

Add EnsureMP3Encoder method to TAudioRecorder for lazy initialization… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonioInfomed wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −3
Open

Add EnsureMP3Encoder method to TAudioRecorder for lazy initialization… #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
712faee
Add EnsureMP3Encoder method to TAudioRecorder for lazy initialization…
Apr 2, 2026
0c71c6d
Refactor MP3 encoding process in TMP3Encoder to use TBytes for file h…
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions AudioRecorder.pas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ TAudioRecorder = class
FCurrentBuffer: Integer;
FDeviceList: TStringList;
FMP3Encoder: TMP3Encoder;
procedure EnsureMP3Encoder;
procedure InitializeWaveFormat;
procedure PrepareBuffers;
procedure UnprepareBuffers;
Expand Down Expand Up @@ -151,14 +152,18 @@ procedure TMP3Encoder.GetLameFunctions;
procedure TMP3Encoder.EncodeFileToMP3(const WavFile, MP3File: string; BitRate: Integer);
var
WavStream, MP3Stream: TMemoryStream;
LBytes: TBytes;
LFile: AnsiString;
begin
WavStream := TMemoryStream.Create;
try
WavStream.LoadFromFile(WavFile);
MP3Stream := EncodeStreamToMP3(WavStream, BitRate);
try
MP3Stream.SaveToFile(MP3File);
beWriteVBRHeader(PAnsiChar(AnsiString(MP3File)));
LBytes := TEncoding.ANSI.GetBytes(MP3File);
SetString(LFile, PAnsiChar(@LBytes[0]), Length(LBytes));
beWriteVBRHeader(PAnsiChar(LFile));
finally
MP3Stream.Free;
end;
Expand Down Expand Up @@ -305,14 +310,20 @@ function TMP3Encoder.EncodeStreamToMP3(WavStream: TStream; BitRate: Integer): TM

{ TAudioRecorder }

procedure TAudioRecorder.EnsureMP3Encoder;
begin
if not Assigned(FMP3Encoder) then
FMP3Encoder := TMP3Encoder.Create;
end;

constructor TAudioRecorder.Create;
begin
inherited;
FDeviceList := TStringList.Create;
FRecordedData := TMemoryStream.Create;
FRecording := False;
FCurrentBuffer := 0;
FMP3Encoder := TMP3Encoder.Create;
FMP3Encoder := nil;
InitializeWaveFormat;
end;

Expand All @@ -321,7 +332,10 @@ destructor TAudioRecorder.Destroy;
FDeviceList.Free;
if FRecording then
StopRecording;
FMP3Encoder.Free;

if (assigned(FMP3Encoder)) then
FMP3Encoder.Free;

FRecordedData.Free;
inherited;
end;
Expand Down Expand Up @@ -554,6 +568,7 @@ function TAudioRecorder.GetMP3Stream(BitRate: Integer): TMemoryStream;
var
WavStream: TMemoryStream;
begin
EnsureMP3Encoder;
WavStream := GetWaveStream;
try
Result := FMP3Encoder.EncodeStreamToMP3(WavStream, BitRate);
Expand Down