Open
Conversation
Contributor
|
Thanks for the PR! I'll be taking a look at this soon. |
csris
reviewed
Mar 29, 2023
Contributor
There was a problem hiding this comment.
I like the direction this patch is going with providing a nice Gradio interface. But, unless I'm missing something, it needs to format the input_text from the text box into a prompt suitable for the language model. Please see inference/conversation.py for a helper class that constructs prompts.
inference/gradio_openchatkit.py
Outdated
| import sys | ||
|
|
||
| CUR_DIR = os.path.abspath(os.path.dirname(__file__)) | ||
| MODEL_PATH = os.path.join(CUR_DIR, "../../GPT-NeoXT-Chat-Base-20B/") |
Contributor
There was a problem hiding this comment.
I believe this should be
Suggested change
| MODEL_PATH = os.path.join(CUR_DIR, "../../GPT-NeoXT-Chat-Base-20B/") | |
| MODEL_PATH = os.path.join(CUR_DIR, "../huggingface_models/GPT-NeoXT-Chat-Base-20B/") |
Author
|
@csris ok, I have updated the code. Thank you! |
Contributor
|
Thanks! Will look. |
justusc
reviewed
May 5, 2023
| response = self.conv.get_last_turn() | ||
|
|
||
| state = state + [(input_text, response)] | ||
| return state, state |
Contributor
There was a problem hiding this comment.
Why is the same state object being returned twice from this function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to add gradio support