Investigation of F2 coefficient of ast_args()#671
Open
fenrir-naru wants to merge 2 commits intotomojitakasu:masterfrom
Open
Investigation of F2 coefficient of ast_args()#671fenrir-naru wants to merge 2 commits intotomojitakasu:masterfrom
fenrir-naru wants to merge 2 commits intotomojitakasu:masterfrom
Conversation
According to pp.23 of Chapter.5 of IERS Conventions (1996), F2 coefficient for 3rd power of t is -0.000136, not 0.000136.
Owner
|
I checked the reference but did not find any problem. https://iers-conventions.obspm.fr/conventions_archive.php Show your reference. |
Author
Owner
|
Thanks. The PS version of IERS Conventions 1996 shows '+ 0".000136 t^3' in F2 (pp. 23). https://iers-conventions.obspm.fr/archive/1996/ierscon.ps The latest IERS Conventions (2010) also shows '+ 0.000136" t^3' in F2 (eq. 5.43, pp. 67). https://www.iers.org/SharedDocs/Publikationen/EN/IERS/Publications/tn/TechnNote36/tn36_043.pdf I'm not sure which is correct but the current code complies with IERS Conventions 2010. |
Author
|
@tomojitakasu Thank you for your further investigation. I agree with your decision. If you like my PR with a comment about the reversion, please merge it, or just close this PR. |
fenrir-naru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to pp.23 of Chapter.5 of IERS Conventions (1996), F2 coefficient for 3rd power of t is -0.000136, not 0.000136.