Skip to content

MAINT: Use uv for installation in the CI.#174

Closed
arokem wants to merge 2 commits intotractometry:mainfrom
arokem:uv
Closed

MAINT: Use uv for installation in the CI.#174
arokem wants to merge 2 commits intotractometry:mainfrom
arokem:uv

Conversation

@arokem
Copy link
Copy Markdown
Member

@arokem arokem commented Feb 10, 2026

This should speed things up quite a bit.

This should speed things up quite a bit.
Copilot AI review requested due to automatic review settings February 10, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions test workflow to use uv for dependency installation to improve CI speed.

Changes:

  • Add astral-sh/setup-uv@v7 to install uv in CI.
  • Replace pip install .[all] with uv pip install .[all].

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

run: |
python -m pip install --upgrade pip
pip install .[all]
uv pip install .[all]
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv pip install generally refuses to install into a non-virtualenv interpreter unless --system is provided (or a venv is created/activated). As written, this CI step is likely to fail on GitHub runners; either add uv pip install --system .[all] or create/activate a venv (e.g., via uv venv) before installing.

Suggested change
uv pip install .[all]
uv pip install --system .[all]

Copilot uses AI. Check for mistakes.
Comment on lines 29 to 31
run: |
python -m pip install --upgrade pip
pip install .[all]
uv pip install .[all]
- name: Nibabel pre-release installation
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now installs the main dependencies with uv, but still uses pip for the nibabel pre-release step and python -m pip check. Mixing installers can lead to inconsistent dependency resolution and may reduce the performance benefit; consider using uv pip install (and uv pip check, if desired) for the later steps as well, or explicitly document why pip is required there.

Copilot uses AI. Check for mistakes.
@arokem
Copy link
Copy Markdown
Member Author

arokem commented Feb 10, 2026

Looks like numba dependencies will not install easily with uv, so I will back off this for now.

@arokem arokem closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants