Fix: Handle timedelta objects in convertDateTimeToUTC() to prevent At…#684
Open
guix77 wants to merge 1 commit intotrakt:mainfrom
Open
Fix: Handle timedelta objects in convertDateTimeToUTC() to prevent At…#684guix77 wants to merge 1 commit intotrakt:mainfrom
guix77 wants to merge 1 commit intotrakt:mainfrom
Conversation
…tributeError - Add type checking for datetime and timedelta objects - Handle timedelta gracefully with error logging and fallback - Prevent crash and memory leak when timedelta is passed instead of datetime/string - Fixes AttributeError: 'datetime.timedelta' object has no attribute 'tzinfo'
razzeee
reviewed
Nov 12, 2025
| "convertDateTimeToUTC() received timedelta object instead of datetime/string: %s. This is a bug. Fallback to datetime utcnow" | ||
| % str(toConvert) | ||
| ) | ||
| return str(datetime.utcnow()) |
Collaborator
There was a problem hiding this comment.
Not sure I want this to not fail hard. This would cause watched timestamps and added at timestamps to be now instead of the correct date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tributeError