feat: Add domainLevels option and remove resend dependency#6
Conversation
1. Added `domainLevels` option to `Passkeys` constructor to configure cookie/RP ID domain depth or explicit domain. 2. Removed `resend` key dependency from `functions/globals.js` as it is out of scope for the library. 3. Updated `src/utils.js` to implement domain level stripping logic. 4. Updated `src/passkeys.js` and `src/sessions.js` to use configured domain. 5. Added tests for numeric domain levels and explicit domain strings. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @treeder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully introduces a domainLevels option for more flexible cookie domain and Relying Party ID configuration, which is a great enhancement for multi-tenant or complex domain setups. The removal of the resend dependency is a good cleanup, simplifying the library's scope. The addition of integration tests for various domain configurations is also a valuable contribution that improves confidence in the changes. I've found one issue in the implementation of the cookieDomain logic that could lead to incorrect behavior when domainLevels is set to 0. Please see my comment for details.
This PR introduces a
domainLevelsoption to thePasskeysconstructor, allowing flexible configuration of the cookie domain and WebAuthn Relying Party ID. This supports both numeric levels (e.g., keeping the last 2 parts of the hostname) and explicit domain strings, falling back to theCOOKIE_DOMAINenvironment variable if not provided.Additionally, this PR removes the
resendintegration fromfunctions/globals.js, as it was identified as being outside the scope of this library.Changes:
src/utils.js: ImplementedcookieDomainlogic to handledomainLevels(numeric or string).src/passkeys.js: PropagateddomainLevelsfrom constructor to context and usedcookieDomainfor RP ID.src/sessions.js: Updated to usecookieDomainfor session cookies.functions/globals.js: Removedresendparsing.functions/v2/auth/[[catchall]].js: PassedCOOKIE_DOMAINenv var asdomainLevels.test/for various domain configurations.PR created automatically by Jules for task 6153692776333184428 started by @treeder