Skip to content

Fix Setuptools>=82 removing pkg_resources#376

Merged
trigg merged 3 commits intotrigg:masterfrom
Super-Pizza:master
Apr 7, 2026
Merged

Fix Setuptools>=82 removing pkg_resources#376
trigg merged 3 commits intotrigg:masterfrom
Super-Pizza:master

Conversation

@Super-Pizza
Copy link
Copy Markdown
Contributor

It made the tool completely broken

Comment thread discover_overlay/voice_overlay.py Outdated

t = gettext.translation(
'default', pkg_resources.resource_filename('discover_overlay', 'locales'), fallback=True)
t = gettext.translation(https://github.com/Super-Pizza/Discover/blob/master/discover_overlay/voice_overlay.py
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a typo :)

@trigg
Copy link
Copy Markdown
Owner

trigg commented Mar 24, 2026

My apologies on the delay to reading this PR.

Small typo but otherwise looks to work fine.

@TheCataliasTNT2k
Copy link
Copy Markdown

Please merge it and create a new release :D
A release in the AUR would also be appreciated, the last update is from 2024...

@trigg
Copy link
Copy Markdown
Owner

trigg commented Mar 27, 2026

I don't have control of the AUR, sadly

@TheCataliasTNT2k
Copy link
Copy Markdown

@Super-Pizza your fix is broken.
See this line: https://github.com/Super-Pizza/Discover/blob/ea34eec70dc7f614fce8933bdae696e9aa406d79/discover_overlay/voice_overlay.py#L33

And compare it to the others you changed.
Something did go wrong somehow.

@Super-Pizza
Copy link
Copy Markdown
Contributor Author

Super-Pizza commented Apr 4, 2026

This is the original code I used:

t = gettext.translation(
    'default', pkg_resources.resource_filename('discover_overlay', 'locales'), fallback=True)

But trigg did a mistake for some reason.

@trigg
Copy link
Copy Markdown
Owner

trigg commented Apr 7, 2026

I've not commited to your branch. You left a mistake where we've both indicated

@TheCataliasTNT2k
Copy link
Copy Markdown

TheCataliasTNT2k commented Apr 7, 2026 via email

@notAxion
Copy link
Copy Markdown

notAxion commented Apr 7, 2026

after reading this docs, it seems like you can just push the changes to your fork and branch you created the pr from, and github will handle the rest

docs = https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

@trigg trigg merged commit ccbee7a into trigg:master Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants