Fix Setuptools>=82 removing pkg_resources#376
Conversation
|
|
||
| t = gettext.translation( | ||
| 'default', pkg_resources.resource_filename('discover_overlay', 'locales'), fallback=True) | ||
| t = gettext.translation(https://github.com/Super-Pizza/Discover/blob/master/discover_overlay/voice_overlay.py |
|
My apologies on the delay to reading this PR. Small typo but otherwise looks to work fine. |
|
Please merge it and create a new release :D |
|
I don't have control of the AUR, sadly |
|
@Super-Pizza your fix is broken. And compare it to the others you changed. |
|
This is the original code I used: t = gettext.translation(
'default', pkg_resources.resource_filename('discover_overlay', 'locales'), fallback=True)But trigg did a mistake for some reason. |
|
I've not commited to your branch. You left a mistake where we've both indicated |
|
I already fixed it locally.
It is pretty easy, just look at the git diff for that commit and compare the changed things with the old state and with each other.
You will see, that the highlighted change "replaced" too much code.
I can not push on that branch afaik so I can not fix it.
Apr 7, 2026 10:14:52 AM trigg ***@***.***>:
…
[Image]*trigg* left a comment (trigg/Discover#376)[#376 (comment)]
I've not commited to your branch. You left a mistake where we've both indicated
—
Reply to this email directly, view it on GitHub[#376 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AKSLSNXQ7PRX3QOQKBV5VJ34US2HXAVCNFSM6AAAAACWCRXYLSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DCOJXGUZDOMZWHA].
You are receiving this because you are subscribed to this thread.
[Tracking image][https://github.com/notifications/beacon/AKSLSNSMTJQKWDR3AXNWXST4US2HXBFCNFSM6AAAAACWCRXYLSWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTX2GEXURJTSMVQXG33OUZWWC3TVMFWA.gif]
|
|
after reading this docs, it seems like you can just push the changes to your fork and branch you created the pr from, and github will handle the rest |
It made the tool completely broken