Skip to content

Return error object when headers already sent in response-validation handler #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: feature/fix-headers-send
Choose a base branch
from
Open

Return error object when headers already sent in response-validation handler #554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
386e27b
Initial plan
Copilot Feb 18, 2026
b85be56
Fix response-validation handler to return error object when headers a…
Copilot Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions src/handlers/response-validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
export default (logger, validateResponse) => (context, request, response) => {
// Prevent sending headers if they're already sent
if (response.headersSent) {
return undefined
}

const responseDoesntNeedValidation = response.statusCode >= 400
if (responseDoesntNeedValidation) {
return response.json(context.response)
Expand All @@ -27,15 +22,16 @@ export default (logger, validateResponse) => (context, request, response) => {
response: context.response
})
}
const errorResponse = {
errors: valid.errors,
status: 502,
timestamp: new Date(),
message: 'Bad response'
}
if (!response.headersSent) {
return response.status(502).json({
errors: valid.errors,
status: 502,
timestamp: new Date(),
message: 'Bad response'
})
return response.status(502).json(errorResponse)
}
return undefined
return errorResponse
}

if (!context.response) {
Expand Down
Loading