-
Notifications
You must be signed in to change notification settings - Fork 146
Misc fixes and improvements [production ready] #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
randshell
wants to merge
31
commits into
trufflesecurity:main
Choose a base branch
from
BeDefended:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix volumes tag - increase healthcheck interval - pin postgres to v16 - remove version tag
- fix volumes tag - increase healthcheck interval - pin postgres to v16 - remove version tag
# Conflicts: # config.env # docker-compose.yml
shouldn't be needed since we have the control panel on a different port
Also add file access permissions
Please see the official docs for preserving IP on a Docker rootless install https://docs.docker.com/engine/security/rootless/troubleshoot/#docker-run--p-does-not-propagate-source-ip-addresses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has been done as part of @BeDefended.
This is an attempt to revive the project by fixing a few known issues. Summary of updates:
.envand is, as such, hidden.Compared to the last MR #62, a few more fixes have been done. Moreover, I've tested the whole MR in a production environment, thus with TLS certificate and email sending functionality, and it should work. The README however needs updating, but reading the comments in the ENV files and Docker compose should already hint at what needs to be adjusted before deploying. Also, these changes are meant for a rootless Docker install, which is the only scenario where this has been tested.
Known bugs / todos: