IMT-124 seed user database with comma separated list#139
IMT-124 seed user database with comma separated list#139cdoyle-temple wants to merge 3 commits intomainfrom
Conversation
.docker/app/Dockerfile
Outdated
| mkdir -p /secure-tmp && chmod 700 /secure-tmp && \ | ||
| mkdir -p /secure-tmp/log && chmod 700 /secure-tmp/log && \ | ||
| rails users:sync_initial | ||
| mkdir -p /secure-tmp/log && chmod 700 /secure-tmp/log |
There was a problem hiding this comment.
if /secure-tmp/ is a volume mount then I think it makes more sense to move creating this direcotry in the entrypoint script because that happens after the container and volumes are mounted vs. here where volumens are not mounted yet.
There was a problem hiding this comment.
@dkinzer This is following a pattern that we have moved to in our other Kubernetes applications. This setup replaces the setup-tmp-dir initContainer that we used to have in our projects. This needs to exist before the containers start to spin up because the tmp directory needs to exist in order for the db-migrate init container to successfully run.
There was a problem hiding this comment.
@sensei100 I'd like for all of us to do a zoom together to test this because i'm still confused how this could be working.
There was a problem hiding this comment.
I don't really want to do a zoom on a Friday afternoon, but we can look at it together on Monday. This is fully working in Tupress and centralized metadata right now if you want to look at where projects where it has already been implemented.
There was a problem hiding this comment.
CM is working inspite of these changes not because of it. If you look inside cm container there is no /secure-tmp/log folder even though it gets created in Dockerfile.
There was a problem hiding this comment.
After a team discussion, we agreed to move the secure-tmp/log line into the entry point.sh file.
|
@cdoyle-temple The title of this PR doesn't match the changes that I see. It looks like we had a discussion and came to an agreement, but the agreed upon change was never made in the code. Can you do that so we can merge this? |
|
@sensei100 I'm not sure why the secure-tmp work is in this PR, but the seeding of initial users is the purpose and is in the code changes. I can break this into two different PRs if that is preferred. |
cdoyle-temple
force-pushed
the
IMT-124-Seed-user-database-with-comma-separated-list
branch
from
37b743f to
7597818
Compare
3 participants
Dockerfile: Runs during image build (no environment variables available)
Entrypoint: Runs when container starts (environment variables available)