[pull] master from ruby:master#812
Merged
pull[bot] merged 11 commits intoturkdevops:masterfrom Feb 27, 2026
Merged
Conversation
They currently complain that the parent method is not forwarding. But the actual problem is that these types of arguments simply don't accept `...` Fixes [Bug #21927] ruby/prism@0aa2363331
When guarding on anything but special const forms (`types::Immediate`), we need to dereference the VALUE to load RBasic::flags and maybe RBasic::class. Those are memory read effects.
Since `GetLocal` (for `level > 0`) is now split into `GetEP` + `LoadField`(#16215), we can remove the Insn and use `LoadSP` instead for the consistency. Also removed a counter that appeared unnecessary.
Unify references in rules that mix positional references and tagged references. Leave the positional reference-only rules unchanged.
The most common cases are nil and hash, so just cover those. If we need to convert to a hash, we can handle that later.
Use get_lvar_level and GetEP instead.
Continuation of #16226. ### Considerations - The OR (`|`) operation in Rust has the same behavior as in Ruby (it compiles to a assembly `or` instruction: https://godbolt.org/z/5McGzj783); - There are no risk of overflows; - In the test, I added the result of the interpreter in an assertion based on feedback of my last PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )