implement the FlatMap typeclass on Job. This allows Job to be used as a Kleisli/Reader#336
Open
gregnwosu wants to merge 7 commits intotypelevel:masterfrom
Open
implement the FlatMap typeclass on Job. This allows Job to be used as a Kleisli/Reader#336gregnwosu wants to merge 7 commits intotypelevel:masterfrom
gregnwosu wants to merge 7 commits intotypelevel:masterfrom
Conversation
… a Reader and composesed
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 96.34% 96.08% -0.26%
==========================================
Files 57 60 +3
Lines 1012 1048 +36
Branches 10 9 -1
==========================================
+ Hits 975 1007 +32
- Misses 37 41 +4
Continue to review full report at Codecov.
|
Contributor
|
Hey @gregnwosu, do you want to keep this open? I would love to merge the PR if you can make the tests pass (adding a test may help with coverage). Let me know if you have any questions. |
Author
|
Yes please I will write the tests this weekend |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pull request allows us to make Job into cats Reader/Kleisli monads. It opens up the proper monad stack for Job and enables the potential to use Job in Monad Transformer stacks . Some example code will probably help explain this best.