Open
Conversation
Member
|
Sorry this has been sitting for so long 😕 I am going to close/re-open the PR to kick-start CI against the latest |
Author
|
@armanbilge No problem, thanks for looking into it :) |
Author
|
There is some failing test but I don't think that it is connected: |
Member
|
Yeah I think that's the known flake ... |
armanbilge
reviewed
Jan 6, 2023
Comment on lines
+1049
to
+1054
| def go(z: O2, s: fs2.Stream[F2, O]): Pull[F2, O2, Unit] = | ||
| s.pull.uncons1.flatMap { | ||
| case Some((hd, tl)) => | ||
| Pull.eval(f(z, hd)).flatMap(o => Pull.output1(o) >> go(o, tl)) | ||
| case None => Pull.done | ||
| } |
Member
There was a problem hiding this comment.
Is this repeated from evalScan? Can we extract it into a private helper evalScan_ like is used for scan/scan1 ?
Author
There was a problem hiding this comment.
Sounds like a good idea, let me try it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I needed such operator today and as it wasn't trivial to write it, so I decided to commit it back to the fs2 repository.