Avoid boxing in ScopedResource.State internals#3140
Avoid boxing in ScopedResource.State internals#3140danicheg wants to merge 1 commit intotypelevel:mainfrom
ScopedResource.State internals#3140Conversation
|
@danicheg So, if we are to have classes with Also, do we have a measure or an intuition as to how many |
|
For these types of changes, where the code is arguably harder to read/work with as a result of the optimization, I'd really like to see benchmarks that prove the performance gain pays off. |
|
That's absolutely fair to ask for numbers to accept any unsafety. I don't know what the hell got into me to bring this PR without a benchmark 😥 |
This is a dispensable performance tweak. The same workaround is already used in fs2, so it should be fine to reuse it once again. But I could be absolutely wrong on that. Don't hesitate to point me at that.