You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds support for mergePreferred like akka provides.
Internally two bounded CE Queues are used, mainly because they provide tryTake for peeking the queue of the preferred stream. If no data is available on the preferred stream, a race is started on both queues. The fibre of the looser will be reused when retrieving the next element.
Testing is kind of hard because race() is not deterministic. Since tests are missing atm, I created this as a draft PR. It's ready for review, but not ready to be merged. Please comment.
Testing is kind of hard because race() is not deterministic.
If you use the mock runtime in TestControl.executeEmbed(...) then they will be deterministic in the sense that all sleeps will be precise e.g. in race(sleep(1.milli), sleep(2.millis)) the left side will always win. Ties will be non-deterministic.
I added some tests, atm without TestControl.executeEmbed. test("mergePreferred prefers") actually cheats by delaying the non-preferred stream. Without the delay, when fetching the first element, a race will be started (since preferredQueue probably would have nothing to offer at that moment), resulting in non-deterministic behaviour (i.e. non-preferred might win the race).
I adjusted the test of the behaviour of mergePreferred to work without any tweaks of timing (i.e. no delay, metered or TestControl.executeEmbed, etc.). It tolerates some (currently 2%) of the elements of the resulting stream to originate from the non preferred stream. This can happen, if the preferred stream did not yet offer an element to its queue, resulting in a race() on both queues, which the non preferred queue might win.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for mergePreferred like akka provides.
Internally two bounded CE Queues are used, mainly because they provide
tryTakefor peeking the queue of the preferred stream. If no data is available on the preferred stream, a race is started on both queues. The fibre of the looser will be reused when retrieving the next element.Testing is kind of hard because race() is not deterministic. Since tests are missing atm, I created this as a draft PR. It's ready for review, but not ready to be merged. Please comment.