Add support for SO_ORIGINAL_DST socket option in scala-native#3656
Merged
mpilquist merged 8 commits intotypelevel:mainfrom Jan 29, 2026
Merged
Add support for SO_ORIGINAL_DST socket option in scala-native#3656mpilquist merged 8 commits intotypelevel:mainfrom
mpilquist merged 8 commits intotypelevel:mainfrom
Conversation
mpilquist
reviewed
Jan 24, 2026
| )(_ == ENOPROTOOPT) | ||
| if (ret == ENOPROTOOPT) None | ||
| else { | ||
| val sockaddr = ptr.asInstanceOf[Ptr[sockaddr_storage]] |
Member
There was a problem hiding this comment.
Can we use toSocketAddress here?
Contributor
Author
There was a problem hiding this comment.
Yes, I suppose that is a very good idea. I changed the PR.
I still suppose that the returned SocketAddress is an IP Address as this option only makes sense in a netfilter context....
What so you think? Is this assumption to unsafe? Are there other situations when the getsockopt would return a socket address?
Let me know, as returning a GenSocketAddress is also possible...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.