Skip Scala.js sourcemap mapping when there are uncommitted changes#881
Merged
armanbilge merged 1 commit intotypelevel:mainfrom Mar 13, 2026
Merged
Conversation
Skips the `mapSourceURI` flag when there are uncommitted changes, since it will be very unlikely to map to a remote source. Source maps can still not exist when the commit is not pushed, but this will at least prevent the source map from being completely broken during local development.
armanbilge
approved these changes
Mar 13, 2026
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
Thanks, good fix.
An alternative implementation I considered is if we should only set the GH sourcemaps when running in GHA CI. But that would be problematic in the unusual but not impossible event that a project has to be published locally. So I think this is the right compromise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips the
mapSourceURIflag when there are uncommitted changes, since it will be very unlikely to map to a remote source.Source maps can still not exist when the commit is not pushed, but this will at least prevent the source map from being completely broken during local development.