FAQ about type refinement from initializers into constructors#7639
FAQ about type refinement from initializers into constructors#7639mernst wants to merge 2 commits intotypetools:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a new FAQ subsection 🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/manual/faq.tex`:
- Around line 888-901: The example classes have mismatched constructor names:
change the no-arg constructors from MyClass() to match their classes (use
MyClass1() for class MyClass1 and MyClass2() for class MyClass2) so the snippets
compile; update the constructor declarations accordingly wherever MyClass()
appears for those classes (referencing class names MyClass1 and MyClass2).
- Around line 880-883: The sentence saying field initializer assignments are
"performed at the beginning of the constructor" is ambiguous; change it to
explicitly state that field initializers run before the constructor body but
after superclass construction (e.g., replace "at the beginning of the
constructor" with "before the constructor body executes (after superclass
construction)") so readers don't misread the initialization order for instance
fields/field initializers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: dcdd8d77-5b5c-44e0-aa28-dda081d284f2
📒 Files selected for processing (1)
docs/manual/faq.tex
No description provided.