Conversation
| @@ -0,0 +1,354 @@ | |||
| #import "@preview/touying:0.6.2": utils | |||
There was a problem hiding this comment.
Consider switching to 0.6.3, a version that fixes a lot of bugs. And make a simple little change:
For theme developers upgrading to v0.6.3:
-
Move
configto the last position inutils.merge-dictsto allow user overrides:// Before self = utils.merge-dicts(self, config, config-page(...)) // After self = utils.merge-dicts(self, config-page(...), config)
-
Replace
paperwithutils.page-args-from-aspect-ratioto support arbitrary aspect ratios:// Before config-page(paper: "presentation-" + aspect-ratio, ...) // After config-page(..utils.page-args-from-aspect-ratio(aspect-ratio), ...)
There was a problem hiding this comment.
Thanks for the suggestion. I would like to migrate to newer version whenever possible.
However, there seems to be an annoying bug exclusive to v0.6.3 that inserts an empty slide when one uses #show: appendix. I just opened an issue in the Touying repository touying-typ/touying#312. I have been trying to rule out the cause of the bug and fix it myself, but no luck yet.
There was a problem hiding this comment.
I did some research, and currently this issue is a bit tricky, so we can temporarily use 0.6.2 for now.
elegaanz
left a comment
There was a problem hiding this comment.
Thank you for this template. Do you want to wait for the Touying issue to be solved or should I already merge this version (once my review comments below are addressed)?
|
|
||
| | flavor | 1 | 2 | 3 | | ||
| |:------:|:---:|:---:|:---:| | ||
| | **`legacy`** | <img src="https://raw.githubusercontent.com/inspiros/touying-greyc-ambrosia/master/assets/samples/sample-legacy-1.webp" width="300"> | <img src="https://raw.githubusercontent.com/inspiros/touying-greyc-ambrosia/master/assets/samples/sample-legacy-2.webp" width="300"> | <img src="https://raw.githubusercontent.com/inspiros/touying-greyc-ambrosia/master/assets/samples/sample-legacy-3.webp" width="300"> | |
There was a problem hiding this comment.
For images in your README, can you please:
- use permalinks (links with a git commit hash or tag name and not a branch name) so that they still reflect what this version of the package does even if you update them in the future in your repository.
- add a short alternative description, to give an idea of what the slides look like to people with poor internet connections or who rely on screen readers.
|
|
||
| > ℹ️ **Note** | ||
| > | ||
| > `touying-greyc-ambrosia` should always be imported after `touying` (which is not necessary and can be removed) in order for the functions and components it overrides to work correctly (e.g. `#alert`, `#show appendix`, ...). |
There was a problem hiding this comment.
I think you are missing a : after the show in the last code snippet here.
|
|
||
| ### Examples | ||
|
|
||
| For more sophisticated use cases, please check [`examples/demo.typ`](https://github.com/inspiros/touying-greyc-ambrosia/blob/master/examples/demo.typ) and [`examples/demo.pdf`](https://github.com/inspiros/touying-greyc-ambrosia/blob/master/examples/demo.pdf). |
There was a problem hiding this comment.
The previous remark applies for links in general: permalinks should be preferred when linking to your own repository.
|
|
||
| ## License | ||
|
|
||
| MIT licensed, see [LICENSE](LICENSE). |
There was a problem hiding this comment.
What about the various logos you ship with this template? Are you allowed to distribute them, and if so under which terms? Can you please check and make that information more explicit?
There was a problem hiding this comment.
I will ask my directeur de thèse, who happens to be the head of communication in the lab, and return to you :/
I am submitting
Description:
touying-greyc-ambrosiais a Touying theme for creating presentation slides with various flavors. It is an unofficial template of the GREYC lab at the Université de Caen Normandie, France.I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE