Skip to content

refactor: SignalRegistry to fetch remote metadata and standardize signals by PID#145

Merged
tzebrowski merged 3 commits intomainfrom
feat/get_pids_def_from_obd_metrics
Apr 6, 2026
Merged

refactor: SignalRegistry to fetch remote metadata and standardize signals by PID#145
tzebrowski merged 3 commits intomainfrom
feat/get_pids_def_from_obd_metrics

Conversation

@tzebrowski
Copy link
Copy Markdown
Owner

This PR enhances the SignalRegistry to automatically pull extended sensor metadata (units, min/max limits) directly from the ObdMetrics repository. It also introduces language-agnostic signal mapping based on PIDs, ensuring consistent charting regardless of the log file's origin language.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Coverage after merging feat/get_pids_def_from_obd_metrics into main will be

88.72%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   alert.js95.65%88.89%100%100%19
   analysis.js89.86%80.65%85.29%96.40%114, 124, 137, 15, 18, 187, 216–217, 22, 229, 23, 32, 39, 47, 90, 94
   bus.js94.59%75%100%100%36, 39
   chartmanager.js76.72%62.66%81.61%84.38%1022–1023, 1025, 1025, 1025, 1025, 1025, 1025, 1025, 1025, 1025, 1025, 1027–1028, 103, 1034–1035, 1038–1039, 1041–1042, 1044–1045, 1048–1049, 1051, 1054, 1074–1075, 108, 1081–1082, 1082, 1082–1084, 109, 1097, 1108, 1129, 1150, 1184–1185, 119, 157–158, 168, 172, 175–176, 182–185, 185, 185–186, 186, 186–187, 220, 226, 278, 281, 286, 289, 293, 303–304, 304, 308, 347, 354, 362, 362–364, 38, 391, 554, 559, 563, 578, 582, 59, 601–604, 606, 613, 624, 63, 632–633, 642, 647, 65, 656, 66, 663, 668, 68, 68, 68, 682–683, 683, 683–684, 684, 684, 686, 69–70, 703, 705, 71, 73, 736, 738, 74, 74, 74–76, 76, 76, 766, 769, 77, 77, 796–797, 80–83, 837, 840, 843, 845–846, 858, 86, 861, 863–865, 874–875, 888–889, 89, 894, 90, 90, 90, 909, 91, 910, 910, 910, 913–914, 914, 914–915, 918, 918, 92, 92, 92, 92, 92, 920, 928–929, 929, 929, 93, 930, 933–934, 934, 934–935, 938, 938, 94, 940, 949, 95, 959, 96, 960–961, 967, 978–979
   config.js77.78%100%0%83.33%35
   dataprocessor.js88.10%78.74%91.67%94.05%153, 153, 153, 156–157, 160, 199, 203–204, 212, 219, 221–222, 239, 253, 261, 270, 276, 301, 304, 330, 334, 340–341, 347, 354, 361, 366, 373, 54, 81–83, 86, 92–95
   dbmanager.js84.13%57.50%85.71%100%108–110, 116, 122–124, 132–134, 29, 33, 56–57, 71, 95–96
   debounce.js100%100%100%100%
   drive.js86.81%74.65%93.62%92.98%126, 137, 143, 162, 194, 203–204, 210–212, 212, 212–213, 217, 224, 224, 224–225, 227, 227, 227, 229–231, 233, 244, 251, 272, 278, 293, 304, 317, 324–325, 335, 345, 348, 355, 361–363, 382, 409, 437, 442, 480, 487, 537, 539, 546, 74–75
   histogram.js85.71%71.43%72.73%96.97%101, 113, 125, 129, 142, 145, 148, 154, 17, 28, 33, 33, 73, 77
   mapmanager.js79.29%65.55%75.76%89.05%102, 106, 106, 106–107, 109–110, 110, 110–112, 130–134, 148, 150, 153–155, 19, 208–209, 209, 28, 286–287, 291, 297, 31, 339, 343, 360, 372, 38, 412, 416, 424, 435, 443, 448, 452, 456–457, 46, 461–462, 483, 488–491, 491, 491, 491, 491–492, 495–496, 500, 509, 515, 517, 521, 524, 532, 535, 538–540, 546–547, 547, 547, 547, 547–548, 555, 563, 569, 578, 587, 611, 621, 624, 636, 642, 642, 650, 657, 657–658, 668, 719, 72, 72, 72, 721, 723, 73–74, 77, 83–85, 87, 91, 91, 91–94, 94, 94, 94, 94, 94–96
   mathchannels.js80.88%70.08%84.91%86.25%100–101, 106, 117, 123, 129–131, 138, 16, 184, 184–185, 188, 197–198, 207, 207, 22, 220, 224, 243–244, 25, 264, 281, 290, 290, 290–295, 297–299, 301, 303, 307, 32, 320, 329, 329, 33, 338–340, 340, 340, 340, 340–343, 347, 363, 369, 372–373, 378, 389, 39, 390, 395, 407, 424, 430–431, 450, 450, 454, 461, 467–471, 482–484, 486–488, 490–494, 497–499, 531, 56, 599, 606, 609, 612, 616, 623, 636–637, 648, 650–651, 67, 670, 688–689, 691, 698, 70, 720, 727, 736–738, 763–765, 77, 80, 800, 81, 827, 84, 842, 853, 857,

@tzebrowski tzebrowski merged commit 30ae220 into main Apr 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant