#440: added util.py:obj_or_id_or_sis_str, use it in course.py:enroll…#522
Open
ndegroot wants to merge 10 commits intoucfopen:developfrom
Open
#440: added util.py:obj_or_id_or_sis_str, use it in course.py:enroll…#522ndegroot wants to merge 10 commits intoucfopen:developfrom
ndegroot wants to merge 10 commits intoucfopen:developfrom
Conversation
…enroll_user to support 'sis_login_id:' syntax
Author
|
I've just checked my code again, run the tests and coverage on Python 3.11 against current state. Still working ok. Please give me feedback why this is still pending. Happy to rework it! |
…ed to latest version 3.3, tests added
Author
|
Added same changes to section.py in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change course.py:enroll_user to also support 'sis_login_id:' syntax
Proposed Changes
Fixes #440 Allow using SIS ids like sis_login_id:[loginname].
Extra important for scripts running under subadmin accounts: in that case the scripts can't use the get_user() function for new users, not enrolled yet in a sub-admin related course because the function is reserved for admins. So subadmin scripts really need this format in course.enroll_user() to be able to enroll a user programmaticly.
Notes: