feat(dev): add table performance test page#4825
Draft
felixfeng33 wants to merge 2 commits intomainfrom
Draft
Conversation
- Add /dev/table-perf route for benchmarking table render performance - React Profiler integration for render timing - Configurable table sizes with presets (10x10 to 60x60) - Benchmark runner: 5 warmup + 20 measured iterations - Statistics: mean, median, P95, P99, stdDev Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
bot
added
the
size:XL
|
- Remove O(n) sync effect in useTableCellElement that caused O(n²) re-renders - Change useIsCellSelected to compare by ID instead of reference - Fix infinite loop in table-perf page profiler callback 20x20 table should now render in <500ms instead of ~2500ms. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dev/table-perfroute for investigating table performance issuesPerformance Fix
useTableCellElementthat caused O(n) operations per celluseIsCellSelectedto compare by ID instead of referenceBefore
Each cell's
useEffectran O(n) checks on every element change, causing cascading re-renders.After
Removed the effect entirely. ID comparison in
useIsCellSelectedhandles stale references.Files Changed
packages/table/src/react/components/TableCellElement/useTableCellElement.ts- Removed sync effectpackages/table/src/react/components/TableCellElement/useIsCellSelected.ts- ID comparisonapps/www/src/app/dev/table-perf/page.tsx- Test page with benchmarkTest Plan
/dev/table-perf