MarkdownPlugin: serialize \n within a text child of a paragraph as line break#4835
Open
dschoorl wants to merge 2 commits intoudecode:mainfrom
Open
MarkdownPlugin: serialize \n within a text child of a paragraph as line break#4835dschoorl wants to merge 2 commits intoudecode:mainfrom
dschoorl wants to merge 2 commits intoudecode:mainfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 7329313 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
dosubot
bot
added
size:M
Member
|
Thanks for the PR. Looks like test is failing. |
dschoorl
force-pushed
the
fix-markdown-linebreak-serialization
branch
from
ab23a04 to
bce26b0
Compare
Author
Yes, I noticed. Those tests pass on my local machine. I am looking into it. |
…ages/code-drawing: This fixes the message when running 'yarn test': Internal Error: @platejs/code-drawing@workspace:packages/code-drawing: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4834 for background
Checklist
yarn typecheckyarn lint:fixyarn testyarn brlyarn changeset