generated from mpppk/ts-react-chrome-ext
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add configurable delay for popup auto-close #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/add-delay-time-for-popup-close
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add configurable delay time for auto-closing popups
Add configurable delay for popup auto-close
Feb 8, 2026
ujiro99
requested changes
Feb 12, 2026
Comment on lines
370
to
383
| // If there are no windows to close, cancel any pending auto-close timer | ||
| if (windowsToClose.length === 0) { | ||
| if (popupAutoCloseTimer !== null) { | ||
| clearTimeout(popupAutoCloseTimer) | ||
| popupAutoCloseTimer = null | ||
| } | ||
| return | ||
| } | ||
|
|
||
| // Cancel any existing timer | ||
| if (popupAutoCloseTimer !== null) { | ||
| clearTimeout(popupAutoCloseTimer) | ||
| popupAutoCloseTimer = null | ||
| } |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
処理が冗長に見えます。キレイのできますか?
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リファクタリングしました。タイマーのクリア処理を最初に一度だけ実行するように変更し、重複を削除しました。(commit: b3fb920)
Co-authored-by: ujiro99 <677231+ujiro99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Plan for Popup Auto-Close Delay
popupAutoCloseDelaysetting to UserSettings typeOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.