Add fullscreen window display mode for page actions #278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fullscreen as a fifth display mode option for page action commands, alongside popup, window, tab, and background tab.
Changes
Core Implementation
FULLSCREEN = "fullscreen"toPAGE_ACTION_OPEN_MODEenum (shared package)POPUP_TYPE.NORMALwindow, then applychrome.windows.update(windowId, { state: "fullscreen" })Services (
packages/extension/src/services/pageAction/background.ts)openAndRunPageAction: handles fullscreen mode during executionopenRecorder: supports fullscreen mode when recording actionsUI (
packages/extension/src/components/option/field/OpenModeToggleField.tsx)Localization
Example Usage
When creating or editing a page action command, users can now select fullscreen mode:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
www.google-analytics.com/opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node --conditions node --conditions development /home/REDACTED/work/selection-command/selection-command/node_modules/tinypool/dist/entry/process.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.