Skip to content

♻️ Standardise more blkt code#4075

Draft
chris-ashe wants to merge 8 commits intomainfrom
standardise_more_blkt_code
Draft

♻️ Standardise more blkt code#4075
chris-ashe wants to merge 8 commits intomainfrom
standardise_more_blkt_code

Conversation

@chris-ashe
Copy link
Collaborator

@chris-ashe chris-ashe commented Jan 30, 2026

This pull request introduces improvements to the blanket structure output and plotting, as well as refactors unit tests for blanket half-height calculation. The main enhancements include a new plotting function for the blanket structure that displays both areas and volumes, streamlining of output methods, and simplification of the unit test for blanket half-height by removing unnecessary patching and parameters.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 41.22449% with 144 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.45%. Comparing base (89a0b72) to head (17b91cf).

Files with missing lines Patch % Lines
process/vacuum.py 26.92% 76 Missing ⚠️
process/blanket_library.py 43.39% 30 Missing ⚠️
process/shield.py 72.30% 18 Missing ⚠️
process/io/plot_proc.py 5.88% 16 Missing ⚠️
process/caller.py 0.00% 2 Missing ⚠️
process/main.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4075      +/-   ##
==========================================
- Coverage   46.46%   46.45%   -0.02%     
==========================================
  Files         122      123       +1     
  Lines       28838    28923      +85     
==========================================
+ Hits        13401    13436      +35     
- Misses      15437    15487      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chris-ashe chris-ashe changed the title Standardise more blkt code ♻️ Standardise more blkt code Jan 30, 2026
@chris-ashe chris-ashe force-pushed the standardise_more_blkt_code branch from 5526a2b to f5c63a2 Compare February 4, 2026 11:25
@chris-ashe chris-ashe force-pushed the standardise_more_blkt_code branch from f5c63a2 to 26d341c Compare February 11, 2026 13:48
@chris-ashe chris-ashe marked this pull request as ready for review February 11, 2026 13:49
@chris-ashe chris-ashe requested a review from a team as a code owner February 11, 2026 13:49
@chris-ashe chris-ashe marked this pull request as draft February 11, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants