Open
Conversation
…iables and update references
…remove redundant logic from Physics class
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
=======================================
Coverage 46.56% 46.57%
=======================================
Files 124 124
Lines 28980 28976 -4
=======================================
Hits 13495 13495
+ Misses 15485 15481 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily fixes a variable naming typo (
plfux_plasma_surface_neutron_avg_mw→pflux_plasma_surface_neutron_avg_mw) throughout the codebase, and refactors the calculation and assignment of first wall neutron and photon power fluxes. The logic for these calculations is moved out ofphysics.pyand consolidated withinfw.py, simplifying and centralizing the power flux computations. Additionally, related output and plotting code is updated to use the corrected variable name.Refactor and relocation of first wall power flux calculations:
pflux_fw_neutron_mwandpflux_fw_rad_mwfromphysics.pytofw.py, consolidating the logic and simplifying the code structure. The new implementation uses a more unified approach for both neutron and photon wall loads, removing configuration-specific branches fromphysics.py.✅ - Within
fw.py🟥 - In
physics.pywith redundant calculation already done byapply_first_wall_coverage_factors()Variable name correction and consistency:
plfux_plasma_surface_neutron_avg_mwtopflux_plasma_surface_neutron_avg_mwacross all relevant files and function signatures, including initialization and output routines.Output and plotting updates:
Code cleanup:
physics.pyand updated import statements to reflect the new locations of relevant calculations.These changes improve code clarity, maintainability, and correctness regarding the calculation and reporting of first wall neutron and photon fluxes.## Description
Checklist
I confirm that I have completed the following checks: