Fix C++ exception error in Significance 'make style from act. line' stuff function.#30
Open
moex3 wants to merge 2 commits intounanimated:masterfrom
Open
Fix C++ exception error in Significance 'make style from act. line' stuff function.#30moex3 wants to merge 2 commits intounanimated:masterfrom
moex3 wants to merge 2 commits intounanimated:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aegisub version:
Aegisub 9676-migration02-168b6f679Example line:
Dialogue: 0,0:02:00.60,0:02:00.64,Default,,0,0,0,,{\b1}testWhen trying to make a new style from this line using Significance, it fails with:
Lua reported a runtime error: C++ exceptionChanging the line insertion code to
subs[-i] = srin line 816, reveals another error message:Invalid or missing field 'bold' in 'style' class subtitle line (expected boolean)Something must have changed, and now Aegisub expects those boolean fields to actually be boolean type. I fixed it by converting those 4 boolean types to an actual boolean typed value.
I also fixed the margins, because it never used the margins from the style even if the margins on the lines were left 0.