Open
Conversation
Fix for the solver ##82 - Change from SL to Eulerian history manager for flux & unknown in NS solver. - Does NOT fix the SL issue. Further investigation required. - Does NOT fix the callback error in the Eulerian history manager.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Navier–Stokes solver’s default history-term managers, moving away from always constructing Semi-Lagrangian operators and toward Eulerian (mesh-based) time-derivative tracking.
Changes:
- Replace default
DuDtconstruction with anEulerian_DDt-based implementation (including grid-based advection correction viaV_fn). - Only construct
DFDtwhen not supplied by the caller, and default it to an Eulerian history manager. - Comment out the prior Semi-Lagrangian constructor blocks in-place.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the solver ##82