Add environment variables and adaptations for more dynamics deployments#19
Open
brightcohen wants to merge 4 commits intounicode-org:mainfrom
Open
Add environment variables and adaptations for more dynamics deployments#19brightcohen wants to merge 4 commits intounicode-org:mainfrom
brightcohen wants to merge 4 commits intounicode-org:mainfrom
Conversation
|
|
Member
|
@brightcohen Just seeing this, thanks for your interest! Could you rebase it? |
sffc
requested changes
Nov 17, 2020
| extendedDescription: "Please fix your commit message to have the same ticket number as the pull request. If the inconsistency is intentional, you can disable this warning with DISABLE_JIRA_ISSUE_MATCH=true in the PR description.", | ||
| badCommit: commitInfo | ||
| }; | ||
| if(process.env.SEARCH_JIRA_ISSUE_IN_COMMIT === "TRUE") { |
Member
There was a problem hiding this comment.
I'd rather this be opt-out rather than opt-in. There are deployments of this tool that might break if they upgrade the code but don't add the corresponding environment variable.
For example, name it DISABLE_JIRA_ISSUE_CHECK (similar to DISABLE_JIRA_ISSUE_MATCH, but it disables all validation, not just ticket number matching)
| github.createStatus("single-commit", pullRequest, multiCommitPass, url, multiCommitMessage) | ||
| ]; | ||
|
|
||
| if (!(process.env.ALLOW_MANY_COMMITS === "TRUE")) { |
Member
There was a problem hiding this comment.
I'd rather if you named this DISABLE_SINGLE_COMMIT_CHECK. Also, please move the "multiCommitPass" and "multiCommitMessage" lines into this if block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to introduce the tool inside our client's network in order to do so I had to adapt few things that i believe would be beneficial to the rest: