fix(vue): enforce types so nested refs can't be in variables#3852
Closed
JoviDeCroock wants to merge 2 commits intomainfrom
Closed
fix(vue): enforce types so nested refs can't be in variables#3852JoviDeCroock wants to merge 2 commits intomainfrom
JoviDeCroock wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d8396cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying urql with
|
| Latest commit: |
d8396cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90aa2694.urql.pages.dev |
| Branch Preview URL: | https://vue-variables-deep-unwrap.urql.pages.dev |
kitten
reviewed
Feb 25, 2026
| return prototype === Object.prototype || prototype === null; | ||
| }; | ||
|
|
||
| const unwrapVariables = (value: unknown): unknown => { |
Member
There was a problem hiding this comment.
I think, this was explicitly removed already before, then re-added, then removed. I don't think we want to get into that loop again. Both is valid and has merit, but the last conclusion was to let people use computed.
JoviDeCroock
force-pushed
the
vue-variables-deep-unwrap
branch
2 times, most recently
from
e26a084 to
d8396cb
Compare
JoviDeCroock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3834
Summary
variablescan be reactive but it's children can't be