fix: correct typos and handle swallowed json.Marshal error#488
Merged
cmainas merged 1 commit intourunc-dev:main-pr488from Feb 17, 2026
Merged
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vinayakjeet
force-pushed
the
fix/typos-and-error-handling
branch
from
2b7e296 to
d03e32c
Compare
- Fix typo 'remobe' -> 'remove' in rootfs.go error message - Fix typo 'socker' -> 'socket' in create.go error message - Replace 'runc' with 'urunc' in user-facing strings - Handle swallowed json.Marshal error in firecracker.go Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com>
Contributor
Author
|
Hi @cmainas fixed the commit header length to pass commitlint and Also rebased onto latest main. Can you please review it .Thanks |
cmainas
approved these changes
Feb 17, 2026
Contributor
cmainas
left a comment
cmainas
left a comment
There was a problem hiding this comment.
Thank you @vinayakjeet for the fixes.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
- Fix typo 'remobe' -> 'remove' in rootfs.go error message - Fix typo 'socker' -> 'socket' in create.go error message - Replace 'runc' with 'urunc' in user-facing strings - Handle swallowed json.Marshal error in firecracker.go PR: #488 Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
urunc-bot bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
- Fix typo 'remobe' -> 'remove' in rootfs.go error message - Fix typo 'socker' -> 'socket' in create.go error message - Replace 'runc' with 'urunc' in user-facing strings - Handle swallowed json.Marshal error in firecracker.go PR: #488 Signed-off-by: vinayakjeet <vinayakjeetog@gmail.com> Reviewed-by: Charalampos Mainas <cmainas@nubificus.co.uk> Approved-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix typos, correct
runc→uruncreferences in user-facing strings, and handle a previously swallowedjson.Marshalerror in the Firecracker config path.Related issues
None
How was this tested?
lint and build
LLM usage
No
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).