Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2644 +/- ##
=======================================
Coverage 46% 46%
- Complexity 6671 6679 +8
=======================================
Files 795 795
Lines 65878 65893 +15
Branches 9870 9878 +8
=======================================
+ Hits 30682 30692 +10
- Misses 32820 32827 +7
+ Partials 2376 2374 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PaulKlint
reviewed
Feb 11, 2026
src/org/rascalmpl/compiler/lang/rascalcore/check/CheckerCommon.rsc
Outdated
Show resolved
Hide resolved
PaulKlint
approved these changes
Feb 11, 2026
Member
PaulKlint
left a comment
PaulKlint
left a comment
There was a problem hiding this comment.
First of all, great finding this obscure problem.
The solution looks fine, with one suggestion to improve performance.
|
PaulKlint
approved these changes
Feb 14, 2026
Member
PaulKlint
left a comment
PaulKlint
left a comment
There was a problem hiding this comment.
Looks fine to me. This probably the cleanest and fastest solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove newlines from MD5 checksums used in logical locations, to make them OS-independent.
Breaking changes
This PR extends normalisation to the complete MD5 input, meaning that any whitespace will be removed. Therefore, hash signatures for many definitions change.
Closes usethesource/rascal-language-servers#965