enable actionbar buttons without graphview being focused

[Bananeweizen]

There are several actionbar buttons which also work fine without the
graphview being focused (e.g. when a code editor currently has focus). Its
those buttons which don't depend on any selection in the graph view.

Therefore always enable those buttons, as that saves the user one click for focusing the graph view:

• refresh
• save screenshot
• toggle link with editor

[marcphilipp]

Well, these are global command handlers but they only work when one of the graph views is active. Thus, I'm not sure we should always enable them.

[Bananeweizen]

You are of course right with that complaint.

Right now all the handlers are bound to the action bar buttons of the graph view. The graph view becomes active because of hitting the button (and also before triggering the handler). So a problem would only come up if the handler were actually used with a UI element outside of the graphview, where I believe the handlers just aren't used in such a way. Have I missed something there?

[marcphilipp]

I think I would rather leave the enablement as is. Ok by you?

[Bananeweizen]

Hm, actually I'm not satisfied with that outcome as the graphview behaves really strange and different than every other view, regarding this enablement.
If you feel uneasy about the enablement, then I would rather add code inside the handler to verify that the active part is a graph view. Would that make the change acceptable on your side?

[marcphilipp]

Sounds good to me!